Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Allow cancel autostop for cluster on k8s #3525

Merged
merged 3 commits into from
May 8, 2024
Merged

[k8s] Allow cancel autostop for cluster on k8s #3525

merged 3 commits into from
May 8, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 8, 2024 •
edited
Loading

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • pytest tests/test_smoke.py::test_autodown --kubernetes with ~/.sky/config.yaml set:
    kubernetes:
  remote_identity: SERVICE_ACCOUNT
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll changed the title [k8s] Allow cancel autostop cluster [k8s] Allow cancel autostop for cluster on k8s May 8, 2024
@Michaelvll Michaelvll requested a review from cblmemo May 8, 2024 09:51
@Michaelvll Michaelvll merged commit 344459b into master May 8, 2024
20 checks passed
@Michaelvll Michaelvll deleted the allow-cancel branch May 8, 2024 10:10
@Michaelvll Michaelvll mentioned this pull request May 10, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblmemo cblmemo cblmemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michaelvll @cblmemo